jungan21 commented on a change in pull request #1804: URL: https://github.com/apache/servicecomb-java-chassis/pull/1804#discussion_r433024225
########## File path: service-registry/registry-zero-config/src/main/java/org/apache/servicecomb/zeroconfig/ZeroConfigDiscovery.java ########## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.servicecomb.zeroconfig; + +import com.netflix.config.DynamicPropertyFactory; +import java.util.Collection; +import java.util.List; +import org.apache.servicecomb.registry.api.Discovery; +import org.apache.servicecomb.registry.api.registry.Microservice; +import org.apache.servicecomb.registry.api.registry.MicroserviceInstance; +import org.apache.servicecomb.registry.api.registry.MicroserviceInstances; +import org.apache.servicecomb.zeroconfig.client.ZeroConfigClient; + +public class ZeroConfigDiscovery implements Discovery { + + private static final String NAME = "zero-config discovery"; + private static final String ENABLED = "servicecomb.zeroconfig.registry.discovery.enabled"; + + private ZeroConfigClient zeroConfigClient = ZeroConfigClient.INSTANCE; + private String revision; + + @Override + public boolean enabled() { + return DynamicPropertyFactory.getInstance().getBooleanProperty(ENABLED, true).get(); + } + + @Override + public void init() { + // done in registration + } + + @Override + public void run() { + // done in registration + } + + @Override + public void destroy() { + // done in registration + } + + @Override + public int getOrder() { + return 101; + } + + @Override + public Microservice getMicroservice(String microserviceId) { + return zeroConfigClient.getMicroservice(microserviceId); + } + + @Override + public List<Microservice> getAllMicroservices() { + return zeroConfigClient.getAllMicroservices(); + } + + @Override + public String getSchema(String microserviceId, Collection<MicroserviceInstance> instances, + String schemaId) { + return zeroConfigClient.getSchema(microserviceId, schemaId); Review comment: wil add // TODO comment ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
