wujimin commented on a change in pull request #1865:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1865#discussion_r449155873
##########
File path:
swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/engine/SwaggerConsumer.java
##########
@@ -34,14 +35,14 @@ public void setConsumerIntf(Class<?> consumerIntf) {
}
public void addOperation(SwaggerConsumerOperation op) {
- operations.put(op.getSchemaOperationId(), op);
+ operations.put(op.getConsumerMethod(), op);
}
- public SwaggerConsumerOperation findOperation(String consumerMethodName) {
- return operations.get(consumerMethodName);
+ public SwaggerConsumerOperation findOperation(Method consumerMethod) {
Review comment:
can still keep `findOperation(String consumerMethodName)`, and mark as
VisiableForTest
this makes test easier
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
