tianxiaoliang commented on a change in pull request #692:
URL:
https://github.com/apache/servicecomb-service-center/pull/692#discussion_r487773886
##########
File path: server/rest/govern/service.go
##########
@@ -178,6 +213,11 @@ func (governService *Service) GetServiceDetail(ctx
context.Context, in *pb.GetSe
serviceInfo.MicroService = service
serviceInfo.MicroServiceVersions = versions
+ if !in.WithShared {
+ serviceInfo.MicroService.Providers =
governService.removeSharedServiceKey(serviceInfo.MicroService.Providers)
+ serviceInfo.Consumers =
governService.removeSharedService(domainProject, serviceInfo.Consumers)
Review comment:
这会导致相当糟糕的性能，能否在第一次遍历时就剔除共享服务
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
