tianxiaoliang commented on a change in pull request #697:
URL:
https://github.com/apache/servicecomb-service-center/pull/697#discussion_r494700397
##########
File path: server/service/ms/datasource.go
##########
@@ -18,10 +18,11 @@ package ms
import (
"context"
pb "github.com/apache/servicecomb-service-center/pkg/registry"
+ "github.com/apache/servicecomb-service-center/server/plugin/registry"
)
type DataSource interface {
- RegisterService(ctx context.Context, service *pb.CreateServiceRequest)
(*pb.CreateServiceResponse, error)
+ RegisterService(ctx context.Context, service *pb.CreateServiceRequest)
(*registry.PluginResponse, error)
Review comment:
why? PluginResponse is a kv spec ,why not use bizz model
##########
File path: server/service/ms/datasource.go
##########
@@ -18,10 +18,11 @@ package ms
import (
"context"
pb "github.com/apache/servicecomb-service-center/pkg/registry"
+ "github.com/apache/servicecomb-service-center/server/plugin/registry"
)
type DataSource interface {
- RegisterService(ctx context.Context, service *pb.CreateServiceRequest)
(*pb.CreateServiceResponse, error)
+ RegisterService(ctx context.Context, service *pb.CreateServiceRequest)
(*registry.PluginResponse, error)
Review comment:
decouple etcd model later please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
