popozy commented on a change in pull request #711:
URL:
https://github.com/apache/servicecomb-service-center/pull/711#discussion_r505123899
##########
File path: server/service/auth/manager.go
##########
@@ -17,14 +17,15 @@ package auth
import (
"fmt"
+ "github.com/apache/servicecomb-service-center/datasource"
"github.com/apache/servicecomb-service-center/pkg/log"
)
-type dataSourceEngine func(opts Options) (DataSource, error)
+type dataSourceEngine func(opts Options) (datasource.DataSource, error)
Review comment:
Just leave the ms,dep,auth decoupled as three fully seperated plugins or
aggreate them to one plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
