little-cui commented on a change in pull request #712:
URL:
https://github.com/apache/servicecomb-service-center/pull/712#discussion_r505204914
##########
File path: datasource/auth.go
##########
@@ -22,7 +22,8 @@ import (
"github.com/apache/servicecomb-service-center/pkg/rbacframe"
)
-type Auth interface {
+// AccountManager contains the RBAC CRUD
+type AccountManager interface {
Review comment:
DONE
##########
File path: datasource/manager.go
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package datasource
+
+import (
+ "fmt"
+ "github.com/apache/servicecomb-service-center/pkg/log"
+)
+
+type dataSourceEngine func(opts Options) (DataSource, error)
+
+var (
+ plugins = make(map[ImplName]dataSourceEngine)
+ dataSourceInst DataSource
+)
+
+// load plugins configuration into plugins
+func Install(pluginImplName string, engineFunc dataSourceEngine) {
+ plugins[ImplName(pluginImplName)] = engineFunc
+}
+
+// construct storage plugin instance
+// invoked by sc main process
+func Init(opts Options) error {
+ if opts.PluginImplName == "" {
+ return nil
+ }
+
+ authDataSourceEngine, ok := plugins[opts.PluginImplName]
+ if !ok {
+ return fmt.Errorf("plugin implement not supported [%s]",
opts.PluginImplName)
+ }
+ var err error
+ dataSourceInst, err = authDataSourceEngine(opts)
+ if err != nil {
+ return err
+ }
+ log.Info(fmt.Sprintf("storage shim plugin [%s@%s] enabled",
opts.PluginImplName, opts.Endpoint))
+ return nil
+}
+
+// usage: auth.Auth().CreateAccount()
+func AccountMgr() DataSource {
+ return dataSourceInst
+}
+
+// usage: dep.DependencyMgr()
Review comment:
DONE
##########
File path: datasource/manager.go
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package datasource
+
+import (
+ "fmt"
+ "github.com/apache/servicecomb-service-center/pkg/log"
+)
+
+type dataSourceEngine func(opts Options) (DataSource, error)
+
+var (
+ plugins = make(map[ImplName]dataSourceEngine)
+ dataSourceInst DataSource
+)
+
+// load plugins configuration into plugins
+func Install(pluginImplName string, engineFunc dataSourceEngine) {
+ plugins[ImplName(pluginImplName)] = engineFunc
+}
+
+// construct storage plugin instance
+// invoked by sc main process
+func Init(opts Options) error {
+ if opts.PluginImplName == "" {
+ return nil
+ }
+
+ authDataSourceEngine, ok := plugins[opts.PluginImplName]
+ if !ok {
+ return fmt.Errorf("plugin implement not supported [%s]",
opts.PluginImplName)
+ }
+ var err error
+ dataSourceInst, err = authDataSourceEngine(opts)
+ if err != nil {
+ return err
+ }
+ log.Info(fmt.Sprintf("storage shim plugin [%s@%s] enabled",
opts.PluginImplName, opts.Endpoint))
+ return nil
+}
+
+// usage: auth.Auth().CreateAccount()
Review comment:
DONE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
