lilai23 commented on a change in pull request #757:
URL: 
https://github.com/apache/servicecomb-service-center/pull/757#discussion_r532043003



##########
File path: etc/conf/syncer.yaml
##########
@@ -36,6 +36,11 @@ registry:
   tlsMount:
     enabled: false
     name: servicecenter
+httpConfig:

Review comment:
       httpserver已改造

##########
File path: etc/conf/syncer.yaml
##########
@@ -36,6 +36,11 @@ registry:
   tlsMount:
     enabled: false
     name: servicecenter
+httpConfig:
+  # Address to trigger full synchronization task
+  httpAddr: 0.0.0.0:30300

Review comment:
       httpserver已改造

##########
File path: syncer/client/sync_client_test.go
##########
@@ -0,0 +1,17 @@
+package client
+
+import (
+       "context"
+       "crypto/tls"
+       "testing"
+)
+
+var c = NewSyncClient("", new(tls.Config))
+
+func TestClient_IncrementPull(t *testing.T) {
+       c.IncrementPull(context.Background(), "http://127.0.0.1";)

Review comment:
       已修改

##########
File path: syncer/http/http.go
##########
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package http
+
+import (
+       "compress/gzip"
+       "context"
+       "github.com/NYTimes/gziphandler"
+       "github.com/apache/servicecomb-service-center/pkg/log"
+       "github.com/apache/servicecomb-service-center/syncer/pkg/utils"
+       "io"
+       "net/http"
+       "sync"
+)
+
+const (
+       Path    = "/v1/syncer/notify"
+       Message = "Deliver full synchronization task success!"
+)
+
+// Server struct
+type Server struct {
+       server    *http.Server

Review comment:
       httpserver已改造




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to