little-cui commented on a change in pull request #773:
URL:
https://github.com/apache/servicecomb-service-center/pull/773#discussion_r540215870
##########
File path: datasource/etcd/event/instance_event_handler.go
##########
@@ -168,7 +168,6 @@ func NotifySyncerInstanceEvent(evt sd.KvEvent,
domainProject string, ms *pb.Micr
Action: string(evt.Type),
Service: service,
Instance: instance,
- Revision: evt.Revision,
Review comment:
删除rev的原因是？
##########
File path: pkg/dump/dump.go
##########
@@ -227,5 +227,4 @@ type WatchInstanceChangedEvent struct {
Action string `protobuf:"bytes,1,opt,name=action"
json:"action,omitempty"`
Service *Microservice `protobuf:"bytes,2,opt,name=service"
json:"service,omitempty"`
Instance *Instance `protobuf:"bytes,3,opt,name=instance"
json:"instance,omitempty"`
- Revision int64 `protobuf:"bytes,4,opt,name=revision"
json:"revision,omitempty"`
Review comment:
接口语义约定了需要有rev来标记本次实例变化的版本，客户端可以判断这次变化对比本地是否一致
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
