tianxiaoliang commented on a change in pull request #170:
URL: https://github.com/apache/servicecomb-kie/pull/170#discussion_r552483559
##########
File path: pkg/validate/instance.go
##########
@@ -17,7 +18,7 @@ var customRules = []*RegexValidateRule{
NewRule("commonName", commonNameRegexString, &Option{Min: 1, Max: 256}),
NewRule("valueType", `^$|^(ini|json|text|yaml|properties)$`, nil),
NewRule("kvStatus", `^$|^(enabled|disabled)$`, nil),
- NewRule("value", asciiRegexString, &Option{Max: 2097152}), //ASCII, 2M
+ NewRule("value", allCharString, &Option{Max: 2097152}), //ASCII, 2M
Review comment:
注释和代码已经不匹配了，应该删除注释，不再维护注释了，但是要在Max字段维护个单位注释，或者学习time.Seconds这样的单位写法，搞成n*size.MegaBytes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
