robotLJW commented on a change in pull request #817:
URL:
https://github.com/apache/servicecomb-service-center/pull/817#discussion_r553711435
##########
File path: syncer/server/server.go
##########
@@ -297,10 +299,15 @@ func instFromOtherSC(instance *dump.Instance, m
*pb.MappingEntry) bool {
func (s *Server) addToQueue(event *dump.WatchInstanceChangedEvent) {
mapping := s.servicecenter.GetSyncMapping()
- for _, m := range mapping {
+ for index, m := range mapping {
if instFromOtherSC(event.Instance, m) {
- log.Debugf("instance[curId:%s, originId:%s] is from
another sc, no need to put to queue",
- m.CurInstanceID, m.OrgInstanceID)
+ log.Debug(fmt.Sprintf("instance[curId:%s, originId:%s]
is from another sc, no need to put to queue",
+ m.CurInstanceID, m.OrgInstanceID))
+
+ if event.Action == string(discovery.EVT_DELETE) {
+ mapping = append(mapping[:index],
mapping[index+1:]...)
Review comment:
好问题，我去学习了下，尝试了下其实ok的，index最大其实是切片的len-1，加+1其实也就是切片的len，返回结果是[]。感谢！我也学习了。thx！
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
