liubao68 commented on a change in pull request #2191:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/2191#discussion_r555706235
##########
File path:
handlers/handler-router/src/main/java/org/apache/servicecomb/router/custom/RouterInvokeFilter.java
##########
@@ -71,9 +71,6 @@ public Response afterReceiveRequest(Invocation invocation,
if (!isHaveHeadersRule()) {
return null;
}
- if
(!RouterRuleCache.isServerContainRule(invocation.getMicroserviceName())) {
- return null;
- }
Review comment:
It's recommended to add a unit test case that cover the logic of
RouterInvokFilter, RouterServerListFilter. Adding this can help to make sure
this module works as expected. Now there is no intergration test for this
module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
