robotLJW commented on a change in pull request #809:
URL:
https://github.com/apache/servicecomb-service-center/pull/809#discussion_r556223711
##########
File path: server/service/rbac/rbac_test.go
##########
@@ -176,8 +176,7 @@ func TestInitRBAC(t *testing.T) {
})
t.Run("delete the new role", func(t *testing.T) {
- r, err := dao.DeleteRole(context.Background(), "tester")
+ _, err := dao.DeleteRole(context.Background(), "tester")
Review comment:
这个我修改了，我发现之前role那块的delete操作最后的判断存在问题，不应该使用count!=0来判断，应该使用resp.Succeeded
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
