liubao68 commented on a change in pull request #2253:
URL: 
https://github.com/apache/servicecomb-java-chassis/pull/2253#discussion_r583321008



##########
File path: 
dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterConfig.java
##########
@@ -71,6 +81,40 @@ private ConfigCenterConfig() {
 
   public static void 
setConcurrentCompositeConfiguration(ConcurrentCompositeConfiguration config) {
     finalConfig = config;
+    readFileSourceConfig();
+  }
+
+  @SuppressWarnings("unchecked")
+  public List<String> getFileSource() {
+    return (List<String>) finalConfig.getProperty(FILE_SOURCE);
+  }
+
+  private static void readFileSourceConfig() {

Review comment:
       This PR is not correct. We are not going to support config yaml files. 
But config yaml contents in config center. Using your test case for example. 
   
   mytest.yaml is a key in config center, and the value of mytest.yaml is the 
file content. 
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to