tianxiaoliang commented on a change in pull request #950:
URL:
https://github.com/apache/servicecomb-service-center/pull/950#discussion_r615198387
##########
File path: datasource/mongo/ms.go
##########
@@ -539,7 +539,7 @@ func (ds *DataSource) GetServicesStatistics(ctx
context.Context, request *discov
ctx = util.WithCacheOnly(ctx)
var st *discovery.Statistics
var err error
- st, err = statistics(ctx, true)
+ st, err = statistics(ctx, false)
Review comment:
既然都是false,为何不把这个参数从函数里干掉,另外,bool作为入参是违反cleancode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]