DFSOrange commented on a change in pull request #953:
URL:
https://github.com/apache/servicecomb-service-center/pull/953#discussion_r615217747
##########
File path: datasource/mongo/ms.go
##########
@@ -1404,13 +1404,80 @@ func getServiceDetailUtil(ctx context.Context, mgs
*model.Service, countOnly boo
}
// Instance management
-func (ds *DataSource) RegisterInstance(ctx context.Context, request
*discovery.RegisterInstanceRequest) (*discovery.RegisterInstanceResponse,
error) {
+func (ds *DataSource) RegisterInstance(ctx context.Context,
+ request *discovery.RegisterInstanceRequest)
(*discovery.RegisterInstanceResponse, error) {
+
+ isCustomID := true
+
+ if len(request.Instance.InstanceId) == 0 {
+ isCustomID = false
+ request.Instance.InstanceId =
uuid.Generator().GetInstanceID(ctx)
+ }
+
+ if isFastRegisterEnabled {
+ // fast register, just add instance to channel and batch
register them later
+ event := &InstanceRegisterEvent{ctx, request, isCustomID, 0}
+ GetFastRegisterInstanceService().AddEvent(event)
+
+ return &discovery.RegisterInstanceResponse{
+ Response:
discovery.CreateResponse(discovery.ResponseSuccess, "Register service instance
successfully."),
+ InstanceId: request.Instance.InstanceId,
+ }, nil
+ }
+
+ return RegisterInstanceSingle(ctx, request, isCustomID)
+}
+
+func RegisterInstanceSingle(ctx context.Context, request
*discovery.RegisterInstanceRequest,
+ isUserDefinedID bool) (*discovery.RegisterInstanceResponse, error) {
+
+ resp, needRegister, err := preProcessRegister(ctx, request.Instance,
isUserDefinedID)
+
+ if err != nil || !needRegister {
+ log.Error("pre process instance err, or instance already
existed", err)
+ return resp, err
+ }
+
+ return registryInstance(ctx, request)
+}
+
+func RegisterInstanceBatch(events []*InstanceRegisterEvent)
(*discovery.RegisterInstanceResponse, error) {
+ instances := make([]interface{}, 0)
Review comment:
可以make([]interface{},0,len(events)),这样events多的时候slice不需要多次扩容
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
