fuziye01 commented on a change in pull request #953:
URL:
https://github.com/apache/servicecomb-service-center/pull/953#discussion_r620797377
##########
File path: datasource/mongo/ms.go
##########
@@ -1404,13 +1404,79 @@ func getServiceDetailUtil(ctx context.Context, mgs
*model.Service, countOnly boo
}
// Instance management
-func (ds *DataSource) RegisterInstance(ctx context.Context, request
*discovery.RegisterInstanceRequest) (*discovery.RegisterInstanceResponse,
error) {
+func (ds *DataSource) RegisterInstance(ctx context.Context,
+ request *discovery.RegisterInstanceRequest)
(*discovery.RegisterInstanceResponse, error) {
+
+ isCustomID := true
Review comment:
因为有异步注册逻辑,会先生成UUID返回。所以把判断流程提前了,后面的流程都会有id, 在生成UUID的时候会判断是不是custom,然后传下去
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]