liubao68 commented on a change in pull request #2387:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/2387#discussion_r634315237
##########
File path:
service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/RegistryUtils.java
##########
@@ -253,6 +253,9 @@ public static void
executeOnEachServiceRegistry(Consumer<ServiceRegistry> action
public static void addExtraServiceRegistry(ServiceRegistry serviceRegistry) {
Objects.requireNonNull(serviceRegistry);
+ if (EXTRA_SERVICE_REGISTRIES.containsKey(serviceRegistry.getName())) {
+ throw new IllegalArgumentException("Register name duplicated!");
Review comment:
reigstriy name {name} is duplicated between implementation {} and {},
please set different names for each implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
