tianxiaoliang commented on a change in pull request #1000:
URL:
https://github.com/apache/servicecomb-service-center/pull/1000#discussion_r637369390
##########
File path: server/service/rbac/dao/account_dao.go
##########
@@ -36,6 +37,9 @@ func CreateAccount(ctx context.Context, a *rbacmodel.Account)
error {
// UpdateAccount updates an account's info, except the password
func UpdateAccount(ctx context.Context, name string, a *rbacmodel.Account)
error {
// todo params validation
+ if len(a.Roles) == 0 {
Review comment:
不
，实际上客户端可以只更新status，不传roles，也可以只更新roles不更新status，所以是在59行那里判断，59行判断不为0就设置roles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
