[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1007: SCB-2176 Refactor rest util

[GitBox]

tianxiaoliang commented on a change in pull request #1007:
URL: 
https://github.com/apache/servicecomb-service-center/pull/1007#discussion_r639425632



##########
File path: server/handler/exception/exception.go
##########
@@ -51,18 +52,19 @@ func (l *Handler) Handle(i *chain.Invocation) {
        i.WithContext(rest.CtxResponse, asyncWriter)
        i.Next(chain.WithFunc(func(ret chain.Result) {
                if !ret.OK {
-                       i.WithContext(rest.CtxResponseStatus, 
l.responseError(w, ret.Err))
+                       i.WithContext(rest.CtxResponseStatus, 
h.responseError(w, ret.Err))
                        return
                }
 
                i.WithContext(rest.CtxResponseStatus, asyncWriter.StatusCode)
                if err := asyncWriter.Flush(); err != nil {
                        log.Error("response writer flush failed", err)
                }
+               h.alarmIfInternalError(asyncWriter.StatusCode, 
util.BytesToStringWithNoCopy(asyncWriter.Body))

Review comment:
       没错误也告警么，异步调用都告警？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org