tianxiaoliang commented on a change in pull request #1029:
URL:
https://github.com/apache/servicecomb-service-center/pull/1029#discussion_r642297244
##########
File path: server/service/rbac/rbac.go
##########
@@ -123,7 +122,7 @@ func initFirstTime(admin string) {
log.Fatal("invalid pwd", err)
return
}
- if err := dao.CreateAccount(context.Background(), a); err != nil {
+ if err := datasource.Instance().CreateAccount(context.Background(), a);
err != nil {
Review comment:
rbacsvc.createxxx
cleancode要求不要暴露内部结构
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
