develpoerX commented on a change in pull request #2527:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/2527#discussion_r696217361
##########
File path:
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/http/StandardHttpServletResponseEx.java
##########
@@ -104,6 +104,12 @@ public Object getAttribute(String key) {
@Override
public CompletableFuture<Void> sendPart(Part part) {
+ if (part == null) {
+ CompletableFuture<Void> defaultFuture = new CompletableFuture<>();
+ defaultFuture.complete(null);
+ return defaultFuture;
Review comment:
done
##########
File path:
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/http/VertxServerResponseToHttpServletResponse.java
##########
@@ -123,7 +123,11 @@ public void internalFlushBuffer() {
@Override
public CompletableFuture<Void> sendPart(Part part) {
DownloadUtils.prepareDownloadHeader(this, part);
-
+ if (part == null) {
+ CompletableFuture<Void> future = new CompletableFuture<>();
+ future.complete(null);
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
