liubao68 commented on a change in pull request #2531:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/2531#discussion_r696270731
##########
File path:
service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/config/ServiceRegistryConfigBuilder.java
##########
@@ -144,19 +144,9 @@ public int getIdleConnectionTimeout() {
DynamicIntProperty property =
DynamicPropertyFactory.getInstance()
.getIntProperty("servicecomb.service.registry.client.timeout.idle",
- ServiceRegistryConfig.DEFAULT_TIMEOUT_IN_SECONDS * 2);
+ ServiceRegistryConfig.DEFAULT_TIMEOUT_IN_SECONDS);
Review comment:
do not change this.
This issue if for servicecomb.rest.client.connection.idleTimeoutInSeconds
and the reason is to keep this time harf of server idle timeout(tomcat,
vertx. etc.) to avoid randomly got closed connection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
