liubao68 commented on a change in pull request #2600:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/2600#discussion_r724639018
##########
File path:
swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/SwaggerUtils.java
##########
@@ -216,8 +218,14 @@ public static void addDefinitions(Swagger swagger, Type
paramType) {
if (null != swagger.getDefinitions()) {
Model tempModel = swagger.getDefinitions().get(entry.getKey());
if (null != tempModel && !tempModel.equals(entry.getValue())) {
- LOGGER.warn("duplicate param model: " + entry.getKey());
- throw new IllegalArgumentException("duplicate param model: " +
entry.getKey());
+ String tempModelClass = (String)
tempModel.getVendorExtensions().get(X_JAVA_CLASS);
+ if
(tempModelClass.equals(entry.getValue().getVendorExtensions().get(X_JAVA_CLASS)))
{
+ swagger.addDefinition(entry.getKey(), tempModel);
+ continue;
+ } else {
+ LOGGER.warn("duplicate param model: " + entry.getKey());
+ throw new IllegalArgumentException("duplicate param model: " +
entry.getKey());
+ }
}
Review comment:
extract a method is better:
```
if(modelNotDuplicate(...)) {
LOGGER.warn("duplicate param model: " + entry.getKey());
throw new IllegalArgumentException("duplicate param model: " +
entry.getKey());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
