ryaninvoker commented on a change in pull request #219:
URL: https://github.com/apache/servicecomb-kie/pull/219#discussion_r725963256
##########
File path: server/pubsub/bus.go
##########
@@ -55,13 +56,16 @@ type Bus struct {
func Init() {
once.Do(func() {
ac := agent.DefaultConfig()
+ sc := serf.DefaultConfig()
+ setSerfAdvertiseAddr(sc, ac.BindAddr)
if config.Configurations.ListenPeerAddr != "" {
ac.BindAddr = config.Configurations.ListenPeerAddr
}
if config.Configurations.AdvertiseAddr != "" {
ac.AdvertiseAddr = config.Configurations.AdvertiseAddr
+ serfAdvertiseAddr :=
strings.Split(config.Configurations.AdvertiseAddr, ":")
Review comment:
gossip会在FinalAdvertiseAddr()中调用net.ParseIP(ip)来解析
serf的advertiseAddr,他需要提供的是ip不是ip+port
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]