tianxiaoliang commented on a change in pull request #1184:
URL: 
https://github.com/apache/servicecomb-service-center/pull/1184#discussion_r774936546



##########
File path: datasource/schema/schema.go
##########
@@ -20,12 +20,17 @@ package schema
 import (
        "context"
        "crypto/md5"
-       "encoding/hex"
+       "fmt"
+
+       "github.com/go-chassis/cari/discovery"
+)
+
+var (
+       ErrSchemaNotFound        = 
discovery.NewError(discovery.ErrSchemaNotExists, "schema ref not found.")
+       ErrSchemaContentNotFound = 
discovery.NewError(discovery.ErrSchemaNotExists, "schema content not found.")
 )
 
 type RefRequest struct {
-       Domain    string
-       Project   string
        ServiceID string `json:"serviceId" bson:"service_id"`

Review comment:
       查询不带domain和project,hash冲突可能会有安全隐患




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to