tianxiaoliang commented on a change in pull request #1205:
URL:
https://github.com/apache/servicecomb-service-center/pull/1205#discussion_r780088426
##########
File path: client/set.go
##########
@@ -1,16 +1,25 @@
package client
import (
+ "errors"
"fmt"
v1sync "github.com/apache/servicecomb-service-center/api/sync/v1"
"github.com/apache/servicecomb-service-center/pkg/log"
"google.golang.org/grpc"
+ "google.golang.org/grpc/resolver"
+ "google.golang.org/grpc/resolver/manual"
+)
+
+var (
+ ErrAddrEmpty = errors.New("addr is empty")
+ ErrConnNil = errors.New("conn is nil")
)
// SetConfig is client configs
type SetConfig struct {
- Addr string
+ Addr []string
Review comment:
复数，还是全拼吧
##########
File path: client/set.go
##########
@@ -1,16 +1,25 @@
package client
import (
+ "errors"
"fmt"
v1sync "github.com/apache/servicecomb-service-center/api/sync/v1"
"github.com/apache/servicecomb-service-center/pkg/log"
"google.golang.org/grpc"
+ "google.golang.org/grpc/resolver"
+ "google.golang.org/grpc/resolver/manual"
+)
+
+var (
+ ErrAddrEmpty = errors.New("addr is empty")
+ ErrConnNil = errors.New("conn is nil")
)
// SetConfig is client configs
type SetConfig struct {
- Addr string
+ Addr []string
+ Scheme string
Review comment:
如何理解schema字段的设计，枚举值有哪些
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
