robotLJW commented on a change in pull request #1285:
URL: 
https://github.com/apache/servicecomb-service-center/pull/1285#discussion_r820230765



##########
File path: datasource/etcd/ms.go
##########
@@ -82,8 +82,6 @@ func (ds *MetadataManager) RegisterService(ctx 
context.Context, request *pb.Crea
                ctx = util.SetContext(ctx, uuid.ContextKey, index)
                service.ServiceId = uuid.Generator().GetServiceID(ctx)

Review comment:
       id 还不能抽取,我看一些测试用例直接调用datasource层,这样入口就不会产生 uuid 测试用例就过不了了




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to