liubao68 commented on code in PR #3188:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/3188#discussion_r922799482
##########
clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/ServiceCenterRegistration.java:
##########
@@ -149,20 +152,29 @@ public void execute() {
}
}
- private void dealIsSwaggerDifferent(Microservice newMicroservice) {
- if (isListEquals(newMicroservice.getSchemas(), microservice.getSchemas()))
{
- return;
+ private boolean isSwaggerDifferent(Microservice newMicroservice) {
+ if (!isListEquals(newMicroservice.getSchemas(),microservice.getSchemas())){
+ return coverAndIgnore();
+ }
+ List<SchemaInfo> schemaInfos
=serviceCenterClient.getServiceSchemasList(newMicroservice.getServiceId(),true);
+ if (!isListEquals(schemaInfos,this.schemaInfos)){
+ return coverAndIgnore();
}
Review Comment:
Do not compare swaggers content. We can not guarantee same content for same
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
