liubao68 commented on code in PR #3251:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/3251#discussion_r934161296
##########
handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsControllerManager.java:
##########
@@ -211,15 +218,25 @@ protected void updateObjMap(String configKey) {
Iterator<Entry<String, AbstractQpsStrategy>> it =
qualifiedNameControllerMap.entrySet().iterator();
while (it.hasNext()) {
Map.Entry<String, AbstractQpsStrategy> entry = it.next();
+ AbstractQpsStrategy qpsStrategy = null;
if (keyMatch(configKey, entry)) {
- AbstractQpsStrategy qpsStrategy = searchQpsController(entry.getKey());
+ qpsStrategy = searchQpsController(entry.getKey());
if (qpsStrategy != null) {
entry.setValue(qpsStrategy);
LOGGER.info("QpsController updated, operationId = [{}], configKey =
[{}], qpsLimit = [{}]",
entry.getKey(), qpsStrategy.getKey(), qpsStrategy.getQpsLimit());
} else {
it.remove();
}
+ } else if (isConfigKeyContainsANY(configKey)) {
+ qpsStrategy = searchQpsController(configKey);
+ if (qpsStrategy != null) {
+ entry.setValue(qpsStrategy);
+ LOGGER.info("QpsController updated, operationId = [{}], configKey =
[{}], qpsLimit = [{}]",
+ entry.getKey(), qpsStrategy.getKey(),
qpsStrategy.getQpsLimit());
Review Comment:
entry.getKey should be configKey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
