WillemJiang commented on code in PR #3377:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/3377#discussion_r991769272
##########
governance/src/main/java/org/apache/servicecomb/governance/utils/CustomMatch.java:
##########
@@ -22,5 +22,6 @@
public interface CustomMatch {
String errorMessageForNotImplements = " didn't implement interface
org.apache.servicecomb.governance.utils.CustomMatch";
String errorMessageForAbstractClass = " should be a instantiable class
rather than abstract class or other else";
+ String infoMessageForCreatingClass = "is not in spring container, create
one and register it to spring container";
Review Comment:
If we don't let the user to use this constant string, it's better just put
them into the log method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]