anantdahiya8 opened a new pull request, #3393: URL: https://github.com/apache/servicecomb-java-chassis/pull/3393
### Summary The order in which the values are returned from `request.getAttributeNames()` and `requestEx.getParameterNames()` is non deterministic because of the use of HashMap(which doesn't guarantee the order of the elements). To make sure the assert handles these cases as well, I have used `containsInAnyOrder` instead of `contains` to make sure the tests are not flaky Bug - https://issues.apache.org/jira/projects/SCB/issues/SCB-2692?filter=allopenissues Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
