little-cui commented on code in PR #261:
URL: https://github.com/apache/servicecomb-kie/pull/261#discussion_r1017940209
##########
server/datasource/etcd/kv/kv_dao.go:
##########
@@ -20,6 +20,7 @@ package kv
import (
"context"
"encoding/json"
+ kierbac "github.com/apache/servicecomb-kie/server/rbac"
Review Comment:
dao层不能反向依赖server
##########
server/resource/v1/kv_resource.go:
##########
@@ -91,6 +91,7 @@ func (r *KVResource) Post(rctx *restful.Context) {
// Put update a kv
func (r *KVResource) Put(rctx *restful.Context) {
var err error
+
Review Comment:
无意义的修改
##########
server/datasource/etcd/kv/kv_dao.go:
##########
@@ -38,6 +39,11 @@ type Dao struct {
}
func (s *Dao) Create(ctx context.Context, kv *model.KVDoc, options
...datasource.WriteOption) (*model.KVDoc, error) {
+ //rbac
Review Comment:
无用的注释
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
