This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git


The following commit(s) were added to refs/heads/master by this push:
     new 787c53874 [SCB-2701] add a test case for encode query plus (#3479)
787c53874 is described below

commit 787c5387426d74e07fea4bda98a977239b4e9a10
Author: liubao68 <[email protected]>
AuthorDate: Tue Nov 15 19:46:39 2022 +0800

    [SCB-2701] add a test case for encode query plus (#3479)
---
 .../demo/jaxrs/client/TestQueryParamSchema.java    | 54 ++++++++++++++++++++++
 .../demo/jaxrs/server/QueryParamSchema.java        | 34 ++++++++++++++
 2 files changed, 88 insertions(+)

diff --git 
a/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/TestQueryParamSchema.java
 
b/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/TestQueryParamSchema.java
new file mode 100644
index 000000000..dccffc20e
--- /dev/null
+++ 
b/demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/TestQueryParamSchema.java
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.jaxrs.client;
+
+import org.apache.servicecomb.demo.CategorizedTestCase;
+import org.apache.servicecomb.demo.TestMgr;
+import org.apache.servicecomb.provider.pojo.RpcReference;
+import org.apache.servicecomb.provider.springmvc.reference.RestTemplateBuilder;
+import org.springframework.stereotype.Component;
+import org.springframework.web.client.RestTemplate;
+
+@Component
+public class TestQueryParamSchema implements CategorizedTestCase {
+  public interface QueryParamService {
+    String testQueryEncode(String param);
+  }
+
+  private final RestTemplate restTemplate = RestTemplateBuilder.create();
+
+  @RpcReference(microserviceName = "jaxrs", schemaId = "QueryParamSchema")
+  private QueryParamService queryParamService;
+
+  @Override
+  public void testAllTransport() throws Exception {
+    testQueryParamEncodingPlus();
+  }
+
+  private void testQueryParamEncodingPlus() {
+    // should encode +
+    TestMgr.check("a+b",
+        
restTemplate.getForObject("servicecomb://jaxrs/queryParam/testQueryEncode?param={1}",
 String.class, "a+b"));
+    // if not encoded, + should be blank
+    TestMgr.check("a b",
+        
restTemplate.getForObject("servicecomb://jaxrs/queryParam/testQueryEncode?param=a+b",
 String.class));
+
+    // rpc should encode
+    TestMgr.check("a+b", queryParamService.testQueryEncode("a+b"));
+  }
+}
diff --git 
a/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/QueryParamSchema.java
 
b/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/QueryParamSchema.java
new file mode 100644
index 000000000..a15ce1b34
--- /dev/null
+++ 
b/demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/QueryParamSchema.java
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.jaxrs.server;
+
+import javax.ws.rs.GET;
+import javax.ws.rs.Path;
+import javax.ws.rs.QueryParam;
+
+import org.apache.servicecomb.provider.rest.common.RestSchema;
+
+@RestSchema(schemaId = "QueryParamSchema")
+@Path("/queryParam")
+public class QueryParamSchema {
+  @Path("testQueryEncode")
+  @GET
+  public String testQueryEncode(@QueryParam("param") String param) {
+    return param;
+  }
+}

Reply via email to