little-cui commented on code in PR #1365:
URL:
https://github.com/apache/servicecomb-service-center/pull/1365#discussion_r1045805569
##########
pkg/privacy/password_test.go:
##########
@@ -117,3 +96,10 @@ func BenchmarkPbkdf2(b *testing.B) {
})
b.ReportAllocs()
}
+func TestDefaultManager(t *testing.T) {
+ privacy.DefaultManager = &mockPassword{}
Review Comment:
执行完，得还原，怕其他UT依赖默认实现
##########
pkg/privacy/password_test.go:
##########
@@ -19,46 +19,25 @@ package privacy_test
import (
"crypto/sha512"
+ "github.com/stretchr/testify/assert"
Review Comment:
执行goimport
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
