liubao68 commented on code in PR #3623:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/3623#discussion_r1102210489
##########
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/TransportClientConfig.java:
##########
@@ -86,6 +86,34 @@ public static boolean getConnectionKeepAlive() {
.get();
}
+ public static int getHttp1ConnectionKeepAliveTimeoutInSeconds() {
+ int result = DynamicPropertyFactory.getInstance()
+
.getIntProperty("servicecomb.rest.client.http1.connection.keepAliveTimeoutInSeconds",
-1)
+ .get();
+ if (result >= 0) {
+ return result;
+ }
+ result = getConnectionIdleTimeoutInSeconds();
+ if (result > 1) {
+ return result - 1;
+ }
+ return result;
+ }
+
+ public static int getHttp2ConnectionKeepAliveTimeoutInSeconds() {
+ int result = DynamicPropertyFactory.getInstance()
+
.getIntProperty("servicecomb.rest.client.http2.connection.keepAliveTimeoutInSeconds",
-1)
+ .get();
+ if (result >= 0) {
+ return result;
+ }
+ result = getConnectionIdleTimeoutInSeconds();
Review Comment:
should be getHttp2ConnectionIdleTimeoutInSeconds?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
