liubao68 commented on code in PR #3801:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/3801#discussion_r1200258886
##########
foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/http/TestHttpUtils.java:
##########
@@ -55,6 +55,21 @@ public void parseParamFromHeaderValue_keyNotFound() {
Assertions.assertNull(HttpUtils.parseParamFromHeaderValue("xx;k=", "kk"));
}
+ @Test
+ public void parseParamFromHeaderValue_valueWithQuotationMark() {
+ Assertions.assertEquals("v",
HttpUtils.parseParamFromHeaderValue("xx;k=\"v\"", "k"));
+ }
+
+ @Test
+ public void parseParamFromHeaderValue_valueWithBlank() {
+ Assertions.assertEquals("v", HttpUtils.parseParamFromHeaderValue("xx;
k=v", "k"));
+ }
+
+ @Test
+ public void parseParamFromHeaderValue_valueWithQuotationMarkAndBlank() {
+ Assertions.assertEquals("v", HttpUtils.parseParamFromHeaderValue("xx;k=
\"v\"", "k"));
+ }
Review Comment:
Maybe the following cases is enough
* key1=a;key2=b
* key1=a; key2=b
* key1="a";key2="b"
* key1="a"; key2="b"
* key1="a"; key2="b c.txt"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
