little-cui commented on code in PR #1425:
URL:
https://github.com/apache/servicecomb-service-center/pull/1425#discussion_r1306318403
##########
server/service/disco/instance.go:
##########
@@ -485,3 +485,8 @@ func InstanceUsage(ctx context.Context, request
*pb.GetServiceCountRequest) (int
}
return resp.Count, nil
}
+
+func UpdateManyInstanceStatus(ctx context.Context, match
datasource.MatchPolicy, status string) error {
Review Comment:
传递引用，match MatchPolicy
##########
datasource/ms.go:
##########
@@ -93,4 +96,6 @@ type MetadataManager interface {
RetireService(ctx context.Context, plan *RetirePlan) error
Statistics(ctx context.Context, withShared bool) (*pb.Statistics, error)
+
+ UpdateManyInstanceStatus(ctx context.Context, match MatchPolicy, status
string) error
Review Comment:
传递引用match *MatchPolicy
##########
datasource/ms.go:
##########
@@ -93,4 +96,6 @@ type MetadataManager interface {
RetireService(ctx context.Context, plan *RetirePlan) error
Statistics(ctx context.Context, withShared bool) (*pb.Statistics, error)
+
+ UpdateManyInstanceStatus(ctx context.Context, match MatchPolicy, status
string) error
Review Comment:
传递引用match *MatchPolicy
##########
server/service/disco/instance.go:
##########
@@ -485,3 +485,8 @@ func InstanceUsage(ctx context.Context, request
*pb.GetServiceCountRequest) (int
}
return resp.Count, nil
}
+
+func UpdateManyInstanceStatus(ctx context.Context, match
datasource.MatchPolicy, status string) error {
Review Comment:
传递引用，match MatchPolicy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
