liubao68 commented on code in PR #4471:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/4471#discussion_r1721181859
##########
service-registry/registry-nacos/src/main/java/org/apache/servicecomb/registry/nacos/NacosDiscovery.java:
##########
@@ -137,7 +138,13 @@ public void run() {
@Override
public void destroy() {
-
+ if (namingService != null) {
+ try {
+ namingService.shutDown();
+ } catch (NacosException e) {
+ throw new IllegalStateException("destroy process is interrupted.");
Review Comment:
Do not throw exception, just add some logs and ignore. Or try catch
exception in SCBEngine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
