This is an automated email from the ASF dual-hosted git repository.
liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git
The following commit(s) were added to refs/heads/master by this push:
new 06ff2f00c [#4477]Fix GoAway issue in Http2 after many requests timeout
(#4487)
06ff2f00c is described below
commit 06ff2f00cd704438810e97970a54a70841082a28
Author: liubao68 <[email protected]>
AuthorDate: Mon Sep 2 14:07:15 2024 +0800
[#4477]Fix GoAway issue in Http2 after many requests timeout (#4487)
---
.../accessLog/core/element/impl/HttpStatusAccessItem.java | 7 -------
.../core/invocation/ProducerInvocationFlow.java | 8 ++++++--
.../apache/servicecomb/samples/WebsocketController.java | 14 ++++++++++++--
.../http/VertxServerResponseToHttpServletResponse.java | 8 ++++++++
4 files changed, 26 insertions(+), 11 deletions(-)
diff --git
a/common/common-access-log/src/main/java/org/apache/servicecomb/common/accessLog/core/element/impl/HttpStatusAccessItem.java
b/common/common-access-log/src/main/java/org/apache/servicecomb/common/accessLog/core/element/impl/HttpStatusAccessItem.java
index f4e8770bd..61be5a790 100644
---
a/common/common-access-log/src/main/java/org/apache/servicecomb/common/accessLog/core/element/impl/HttpStatusAccessItem.java
+++
b/common/common-access-log/src/main/java/org/apache/servicecomb/common/accessLog/core/element/impl/HttpStatusAccessItem.java
@@ -21,15 +21,11 @@ import
org.apache.servicecomb.common.accessLog.core.element.AccessLogItem;
import org.apache.servicecomb.core.event.InvocationFinishEvent;
import org.apache.servicecomb.core.event.ServerAccessLogEvent;
import org.apache.servicecomb.swagger.invocation.Response;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import io.vertx.core.http.HttpServerResponse;
import io.vertx.ext.web.RoutingContext;
public class HttpStatusAccessItem implements AccessLogItem<RoutingContext> {
- private static final Logger LOGGER =
LoggerFactory.getLogger(HttpStatusAccessItem.class);
-
public static final String EMPTY_RESULT = "-";
@Override
@@ -40,9 +36,6 @@ public class HttpStatusAccessItem implements
AccessLogItem<RoutingContext> {
return;
}
if (response.closed() && !response.ended()) {
- LOGGER.warn(
- "Response is closed before sending any data. "
- + "Please check idle connection timeout for provider is properly
configured.");
builder.append(EMPTY_RESULT);
return;
}
diff --git
a/core/src/main/java/org/apache/servicecomb/core/invocation/ProducerInvocationFlow.java
b/core/src/main/java/org/apache/servicecomb/core/invocation/ProducerInvocationFlow.java
index 7304fabae..ec589f377 100644
---
a/core/src/main/java/org/apache/servicecomb/core/invocation/ProducerInvocationFlow.java
+++
b/core/src/main/java/org/apache/servicecomb/core/invocation/ProducerInvocationFlow.java
@@ -72,7 +72,9 @@ public abstract class ProducerInvocationFlow {
if (throwable != null) {
// Server codec operates on Response. So the filter chain result
should be Response and
// will never throw exception.
- LOGGER.error("Maybe a fatal bug that should be addressed.",
throwable);
+ // Sometimes Server Codec will throw exception, e.g. Connection
Closed.
+ LOGGER.error("Maybe a fatal bug that should be addressed or
codec exception for {}.",
+ invocation.getInvocationQualifiedName(), throwable);
response = Response.createFail(new
InvocationException(Status.INTERNAL_SERVER_ERROR,
new CommonExceptionData("Internal error, check logs for
details.")));
}
@@ -87,7 +89,9 @@ public abstract class ProducerInvocationFlow {
if (throwable != null) {
// Server codec operates on Response. So the filter chain result
should be Response and
// will never throw exception.
- LOGGER.error("Maybe a fatal bug that should be addressed.",
throwable);
+ // Sometimes Server Codec will throw exception, e.g. Connection
Closed.
+ LOGGER.error("Maybe a fatal bug that should be addressed or codec
exception for {}.",
+ invocation.getInvocationQualifiedName(), throwable);
response = Response.createFail(new
InvocationException(Status.INTERNAL_SERVER_ERROR,
new CommonExceptionData("Internal error, check logs for
details.")));
}
diff --git
a/demo/demo-zookeeper/provider/src/main/java/org/apache/servicecomb/samples/WebsocketController.java
b/demo/demo-zookeeper/provider/src/main/java/org/apache/servicecomb/samples/WebsocketController.java
index 9ecf678a1..5f4f9719c 100644
---
a/demo/demo-zookeeper/provider/src/main/java/org/apache/servicecomb/samples/WebsocketController.java
+++
b/demo/demo-zookeeper/provider/src/main/java/org/apache/servicecomb/samples/WebsocketController.java
@@ -33,14 +33,24 @@ public class WebsocketController {
@PostMapping("/websocket")
@Transport(name = CoreConst.WEBSOCKET)
public void websocket(ServerWebSocket serverWebsocket) {
+ // Client may have not registered message handler, and messages sent may
get lost.
+ // So we sleep for a while to send message.
AtomicInteger receiveCount = new AtomicInteger(0);
- serverWebsocket.writeTextMessage("hello", r -> {
- });
serverWebsocket.textMessageHandler(s -> {
receiveCount.getAndIncrement();
});
serverWebsocket.closeHandler((v) -> System.out.println("closed"));
+
new Thread(() -> {
+ try {
+ Thread.sleep(1000);
+ } catch (InterruptedException e) {
+ e.printStackTrace();
+ }
+
+ serverWebsocket.writeTextMessage("hello", r -> {
+ });
+
for (int i = 0; i < 5; i++) {
serverWebsocket.writeTextMessage("hello " + i, r -> {
});
diff --git
a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/http/VertxServerResponseToHttpServletResponse.java
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/http/VertxServerResponseToHttpServletResponse.java
index bd4f45b5e..81785e969 100644
---
a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/http/VertxServerResponseToHttpServletResponse.java
+++
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/http/VertxServerResponseToHttpServletResponse.java
@@ -17,6 +17,7 @@
package org.apache.servicecomb.foundation.vertx.http;
+import java.io.IOException;
import java.util.Collection;
import java.util.Objects;
import java.util.concurrent.CompletableFuture;
@@ -116,6 +117,9 @@ public class VertxServerResponseToHttpServletResponse
extends AbstractHttpServle
}
public void internalFlushBuffer() {
+ if (serverResponse.closed()) {
+ return;
+ }
serverResponse.end();
}
@@ -130,6 +134,10 @@ public class VertxServerResponseToHttpServletResponse
extends AbstractHttpServle
@Override
public CompletableFuture<Void> sendBuffer(Buffer buffer) {
+ if (serverResponse.closed()) {
+ return CompletableFuture.failedFuture(new IOException("Response is
closed before sending any data. "
+ + "Maybe client is timeout or check idle connection timeout for
provider is properly configured."));
+ }
CompletableFuture<Void> future = new CompletableFuture<>();
serverResponse.write(buffer).onComplete(result -> {
if (result.failed()) {
