liubao68 commented on code in PR #4486:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/4486#discussion_r1740280548
##########
clients/http-client-common/src/main/java/org/apache/servicecomb/http/client/common/AbstractAddressManager.java:
##########
@@ -53,42 +51,37 @@ public class AbstractAddressManager {
private static final String V3_PREFIX = "/v3/";
- private static final int DEFAULT_METRICS_WINDOW_TIME = 1;
+ private static final int DEFAULT_ADDRESS_CHECK_TIME = 30;
private static final int ISOLATION_THRESHOLD = 3;
- private List<String> addresses = new ArrayList<>();
+ private volatile List<String> addresses = new ArrayList<>();
+
+ private final List<String> default_isolation_address = new ArrayList<>();
private int index;
private String projectName;
// if address in same zone will be true; others will be false.
- private final Map<String, Boolean> addressCategory = new HashMap<>();
+ private final Set<String> addressCategory = new HashSet<>();
Review Comment:
code comments not correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
