liubao68 commented on code in PR #4640: URL: https://github.com/apache/servicecomb-java-chassis/pull/4640#discussion_r1896725734
########## core/src/test/java/org/apache/servicecomb/core/TestInvocation.java: ########## @@ -1,278 +1,282 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package org.apache.servicecomb.core; - -import java.util.Arrays; -import java.util.Map; - -import org.apache.servicecomb.core.definition.InvocationRuntimeType; -import org.apache.servicecomb.core.definition.OperationMeta; -import org.apache.servicecomb.core.event.InvocationBaseEvent; -import org.apache.servicecomb.core.event.InvocationBusinessMethodStartEvent; -import org.apache.servicecomb.core.event.InvocationFinishEvent; -import org.apache.servicecomb.core.event.InvocationStartEvent; -import org.apache.servicecomb.core.provider.consumer.ReferenceConfig; -import org.apache.servicecomb.core.tracing.BraveTraceIdGenerator; -import org.apache.servicecomb.core.tracing.TraceIdGenerator; -import org.apache.servicecomb.foundation.common.Holder; -import org.apache.servicecomb.foundation.common.event.EventManager; -import org.apache.servicecomb.foundation.common.utils.SPIServiceUtils; -import org.apache.servicecomb.foundation.vertx.http.HttpServletRequestEx; -import org.apache.servicecomb.swagger.invocation.Response; -import org.hamcrest.MatcherAssert; -import org.hamcrest.Matchers; -import org.junit.AfterClass; -import org.junit.BeforeClass; -import org.junit.Test; -import org.junit.jupiter.api.Assertions; - -import com.google.common.eventbus.EventBus; -import com.google.common.eventbus.Subscribe; - -import mockit.Expectations; -import mockit.Mock; -import mockit.MockUp; -import mockit.Mocked; - -public class TestInvocation { - Invocation invocation; - - @Mocked - Endpoint endpoint; - - @Mocked - OperationMeta operationMeta; - - @Mocked - InvocationRuntimeType invocationRuntimeType; - - @Mocked - Map<String, Object> arguments; - - static long nanoTime = 123; - - @BeforeClass - public static void classSetup() { - EventManager.eventBus = new EventBus(); - } - - protected static void mockNonaTime() { - new MockUp<System>() { - @Mock - long nanoTime() { - return nanoTime; - } - }; - } - - @AfterClass - public static void classTeardown() { - EventManager.eventBus = new EventBus(); - } - - @Test - public void onStart() { - Holder<Invocation> result = new Holder<>(); - Object subscriber = new Object() { - @Subscribe - public void onStart(InvocationStartEvent event) { - result.value = event.getInvocation(); - } - }; - EventManager.register(subscriber); - - Invocation invocation = new Invocation(endpoint, operationMeta, arguments); - invocation.onStart(); - - Assertions.assertSame(invocation, result.value); - EventManager.unregister(subscriber); - } - - @Test - public void onFinish() { - mockNonaTime(); - - Holder<InvocationFinishEvent> result = new Holder<>(); - Object subscriber = new Object() { - @Subscribe - public void onStart(InvocationFinishEvent event) { - result.value = event; - } - }; - EventManager.register(subscriber); - - Invocation invocation = new Invocation(endpoint, operationMeta, arguments); - Assertions.assertFalse(invocation.isFinished()); - Response response = Response.succResp(null); - invocation.onFinish(response); - - Assertions.assertSame(invocation, result.value.getInvocation()); - Assertions.assertSame(response, result.value.getResponse()); - Assertions.assertTrue(invocation.isFinished()); - - // should not post event again - InvocationFinishEvent oldEvent = result.value; - invocation.onFinish(null); - Assertions.assertSame(oldEvent, result.value); - - EventManager.unregister(subscriber); - } - - @Test - public void isConsumer_yes() { - Invocation invocation = new Invocation(endpoint, operationMeta, arguments); - Assertions.assertFalse(invocation.isConsumer()); - } - - @Test - public void isConsumer_no(@Mocked ReferenceConfig referenceConfig) { - Invocation invocation = new Invocation(referenceConfig, operationMeta, invocationRuntimeType, arguments); - Assertions.assertTrue(invocation.isConsumer()); - } - - @Test - public void localContext(@Mocked ReferenceConfig referenceConfig) { - Invocation invocation = new Invocation(referenceConfig, operationMeta, invocationRuntimeType, arguments); - - invocation.addLocalContext("k", 1); - Assertions.assertSame(invocation.getHandlerContext(), invocation.getLocalContext()); - Assertions.assertEquals(1, (int) invocation.getLocalContext("k")); - } - - @Test - public void traceId_fromContext(@Mocked ReferenceConfig referenceConfig) { - Invocation invocation = new Invocation(referenceConfig, operationMeta, invocationRuntimeType, arguments); - invocation.addContext(CoreConst.TRACE_ID_NAME, "abc"); - - invocation.onStart(); - - Assertions.assertEquals("abc", invocation.getTraceId()); - Assertions.assertEquals("abc", invocation.getTraceId(CoreConst.TRACE_ID_NAME)); - } - - @Test - public void traceId_consumerCreateTraceId(@Mocked ReferenceConfig referenceConfig) { - TraceIdGenerator generator = SPIServiceUtils.getTargetService(TraceIdGenerator.class, BraveTraceIdGenerator.class); - new Expectations(generator) { - { - generator.generate(); - result = "abc"; - } - }; - Invocation invocation = new Invocation(referenceConfig, operationMeta, invocationRuntimeType, arguments); - - invocation.onStart(); - - Assertions.assertEquals("abc", invocation.getTraceId()); - Assertions.assertEquals("abc", invocation.getTraceId(CoreConst.TRACE_ID_NAME)); - } - - @Test - public void traceId_fromRequest(@Mocked Endpoint endpoint, @Mocked HttpServletRequestEx requestEx) { - new Expectations() { - { - requestEx.getHeader(CoreConst.TRACE_ID_NAME); - result = "abc"; - } - }; - Invocation invocation = new Invocation(endpoint, operationMeta, arguments); - - invocation.onStart(requestEx); - - Assertions.assertEquals("abc", invocation.getTraceId()); - Assertions.assertEquals("abc", invocation.getTraceId(CoreConst.TRACE_ID_NAME)); - } - - @Test - public void traceId_producerCreateTraceId(@Mocked Endpoint endpoint, @Mocked HttpServletRequestEx requestEx) { - TraceIdGenerator generator = SPIServiceUtils.getTargetService(TraceIdGenerator.class, BraveTraceIdGenerator.class); - new Expectations(generator) { - { - generator.generate(); - result = "abc"; - } - }; - Invocation invocation = new Invocation(endpoint, operationMeta, arguments); - - invocation.onStart(requestEx); - - Assertions.assertEquals("abc", invocation.getTraceId()); - Assertions.assertEquals("abc", invocation.getTraceId(CoreConst.TRACE_ID_NAME)); - } - - @Test - public void traceIdGeneratorInit(@Mocked TraceIdGenerator gen1, @Mocked TraceIdGenerator gen2, - @Mocked TraceIdGenerator gen3, @Mocked TraceIdGenerator gen4) { - new Expectations(SPIServiceUtils.class) { - { - gen1.getName(); - result = "zipkin"; - - gen3.getName(); - result = "apm"; - - gen2.getName(); - result = "zipkin"; - - gen4.getName(); - result = "apm"; - - SPIServiceUtils.getOrLoadSortedService(TraceIdGenerator.class); - result = Arrays.asList(gen1, gen3, gen2, gen4); - } - }; - - MatcherAssert.assertThat(Invocation.loadTraceIdGenerators(), Matchers.containsInAnyOrder(gen1, gen3)); - } - - InvocationBaseEvent invocationBaseEvent; - - @Test - public void test_business_execute_time_correct() { - Object listener = new Object() { - @Subscribe - public void onBusinessMethodStart(InvocationBusinessMethodStartEvent event) { - invocationBaseEvent = event; - } - }; - EventManager.getEventBus().register(listener); - Invocation invocation = new Invocation(endpoint, operationMeta, arguments); - mockNonaTime(); - invocation.onBusinessMethodStart(); - EventManager.getEventBus().unregister(listener); - - Assertions.assertSame(invocation, invocationBaseEvent.getInvocation()); - nanoTime++; - invocation.onBusinessFinish(); - Assertions.assertEquals(1, invocation.getInvocationStageTrace().calcBusinessExecute()); - } - - @Test - public void marker(@Mocked ReferenceConfig referenceConfig) { - Invocation.INVOCATION_ID.set(0); - - Invocation invocation = new Invocation(referenceConfig, operationMeta, invocationRuntimeType, arguments); - invocation.addContext(CoreConst.TRACE_ID_NAME, "abc"); - invocation.onStart(); - Assertions.assertEquals("abc", invocation.getTraceIdLogger().getName()); - - invocation = new Invocation(referenceConfig, operationMeta, invocationRuntimeType, arguments); - invocation.addContext(CoreConst.TRACE_ID_NAME, "abc"); - invocation.onStart(); - Assertions.assertEquals("abc", invocation.getTraceIdLogger().getName()); - } -} +///* +// * Licensed to the Apache Software Foundation (ASF) under one or more +// * contributor license agreements. See the NOTICE file distributed with +// * this work for additional information regarding copyright ownership. +// * The ASF licenses this file to You under the Apache License, Version 2.0 +// * (the "License"); you may not use this file except in compliance with +// * the License. You may obtain a copy of the License at +// * +// * http://www.apache.org/licenses/LICENSE-2.0 +// * +// * Unless required by applicable law or agreed to in writing, software +// * distributed under the License is distributed on an "AS IS" BASIS, +// * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// * See the License for the specific language governing permissions and +// * limitations under the License. +// */ +//package org.apache.servicecomb.core; +// +//import java.util.Arrays; +//import java.util.Map; +// +//import org.apache.logging.log4j.core.util.internal.InternalLoggerRegistry; +//import org.apache.servicecomb.core.definition.InvocationRuntimeType; +//import org.apache.servicecomb.core.definition.OperationMeta; +//import org.apache.servicecomb.core.event.InvocationBaseEvent; +//import org.apache.servicecomb.core.event.InvocationBusinessMethodStartEvent; +//import org.apache.servicecomb.core.event.InvocationFinishEvent; +//import org.apache.servicecomb.core.event.InvocationStartEvent; +//import org.apache.servicecomb.core.provider.consumer.ReferenceConfig; +//import org.apache.servicecomb.core.tracing.BraveTraceIdGenerator; +//import org.apache.servicecomb.core.tracing.TraceIdGenerator; +//import org.apache.servicecomb.foundation.common.Holder; +//import org.apache.servicecomb.foundation.common.event.EventManager; +//import org.apache.servicecomb.foundation.common.utils.SPIServiceUtils; +//import org.apache.servicecomb.foundation.vertx.http.HttpServletRequestEx; +//import org.apache.servicecomb.swagger.invocation.Response; +//import org.hamcrest.MatcherAssert; +//import org.hamcrest.Matchers; +//import org.junit.AfterClass; +//import org.junit.BeforeClass; +//import org.junit.Test; +//import org.junit.jupiter.api.Assertions; +//import org.mockito.Mockito; +// +//import com.google.common.eventbus.EventBus; +//import com.google.common.eventbus.Subscribe; +// +//import mockit.Deencapsulation; +//import mockit.Expectations; +//import mockit.Mock; +//import mockit.MockUp; +//import mockit.Mocked; +// +//public class TestInvocation { +// Invocation invocation; Review Comment: Would you mind change jmockit to mockitio and fix the failure test cases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
