chenshouye168 commented on code in PR #4670:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/4670#discussion_r1909902126
##########
service-registry/registry-nacos/src/main/java/org/apache/servicecomb/registry/nacos/NacosDiscoveryInstance.java:
##########
@@ -57,7 +57,15 @@ public NacosDiscoveryInstance(Instance instance, String
application, String serv
@Override
public MicroserviceInstanceStatus getStatus() {
- return instance.isEnabled() ? MicroserviceInstanceStatus.UP :
MicroserviceInstanceStatus.DOWN;
+ if (instance.isEnabled()) {
+ String instanceStatus =
instance.getMetadata().get(NacosConst.NACOS_STATUS);
+ if (StringUtils.isBlank(instanceStatus)) {
Review Comment:
U said "instance.getMetadata().get(NacosConst.NACOS_STATUS maybe null for
old versions instance." before,so i do it .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
