yhs0092 commented on code in PR #4809:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/4809#discussion_r2082959097
##########
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/client/http/HttpClientPoolFactory.java:
##########
@@ -46,7 +46,7 @@ public HttpClientWithContext createClientPool(Context
context) {
connection.localAddress(), connection.remoteAddress())
);
connection.exceptionHandler(e ->
- LOGGER.info("http connection exception, local:{}, remote:{}.",
+ LOGGER.error("http connection exception, local:{}, remote:{}.",
Review Comment:
> This may print a lot of logs in situation like: health check, connection
pool resize and other.
Hi, is there real user case? The common health check connection issue is
about server side: the Nginx establish a TCP connection to the server and then
close it, leaving a connection exception on the backend server side. But this
is a client pool, not a server pool.
I guess whether we print the stacktrace depends on whether we have actually
seen many such logs. Or at least, we should print the exception filtered by
`ExceptionUtils.getExceptionMessageWithoutTrace`.
Currently, the log totally doesn't carry the exception message:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
