yhs0092 commented on code in PR #4781:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/4781#discussion_r2083922225
##########
service-registry/registry-service-center/src/main/java/org/apache/servicecomb/serviceregistry/task/MicroserviceInstanceRegisterTask.java:
##########
@@ -113,4 +114,9 @@ public void run() {
srClient.checkIsolationAddressAvailable();
}
}
+
+ @VisibleForTesting
+ public void setAddrCheckInit(boolean addrCheckInit) {
Review Comment:
It's not recommended to expose the hiden property for UT purpose. If this
method is only used for `TestMicroserviceInstanceRegisterTask`, you can delete
the `public` modifier. Just exposing `isAddrCheckInit` property to the classes
under the same package seems enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
