liubao68 commented on code in PR #4812:
URL:
https://github.com/apache/servicecomb-java-chassis/pull/4812#discussion_r2092628269
##########
clients/config-center-client/src/main/java/org/apache/servicecomb/config/center/client/ConfigCenterClient.java:
##########
@@ -66,7 +66,8 @@ public void setEventBus(EventBus eventBus) {
}
@Override
- public QueryConfigurationsResponse
queryConfigurations(QueryConfigurationsRequest request, String address) {
+ public QueryConfigurationsResponse
queryConfigurations(QueryConfigurationsRequest request, String address,
+ boolean isFirstPull) {
String dimensionsInfo = buildDimensionsInfo(request, true);
QueryConfigurationsResponse queryConfigurationsResponse = new
QueryConfigurationsResponse();
Review Comment:
I'd prefer not merge this PR because it just add some logs and changed the
interface definition. Maybe new solutions can have. e.g. add logs for all
config centers and make it optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
