yhs0092 commented on code in PR #4875: URL: https://github.com/apache/servicecomb-java-chassis/pull/4875#discussion_r2264611657
########## common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/produce/ProduceEventStreamProcessor.java: ########## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.servicecomb.common.rest.codec.produce; + +import java.io.InputStream; +import java.io.OutputStream; +import java.nio.charset.StandardCharsets; + +import org.apache.commons.lang3.StringUtils; +import org.apache.servicecomb.common.rest.codec.RestObjectMapperFactory; +import org.apache.servicecomb.swagger.invocation.sse.SseEventResponseEntity; + +import com.fasterxml.jackson.databind.JavaType; + +import jakarta.ws.rs.core.MediaType; + +public class ProduceEventStreamProcessor implements ProduceProcessor { + private int writeIndex = 0; + + @Override + public String getName() { + return MediaType.SERVER_SENT_EVENTS; + } + + @Override + public int getOrder() { + return 0; + } + + @Override + public void doEncodeResponse(OutputStream output, Object result) throws Exception { + StringBuilder bufferBuilder = new StringBuilder(); + if (result instanceof SseEventResponseEntity<?> responseEntity) { + appendEventId(bufferBuilder, responseEntity.getEventId()); + appendEvent(bufferBuilder, responseEntity.getEvent()); + appendRetry(bufferBuilder, responseEntity.getRetry()); + appendData(bufferBuilder, responseEntity.getData()); + } else { + appendEventId(bufferBuilder, writeIndex++); + appendData(bufferBuilder, result); + } + bufferBuilder.append("\n"); + output.write(bufferBuilder.toString().getBytes(StandardCharsets.UTF_8)); + } + + @Override + public Object doDecodeResponse(InputStream input, JavaType type) throws Exception { + String buffer = new String(input.readAllBytes(), StandardCharsets.UTF_8); + SseEventResponseEntity<?> responseEntity = new SseEventResponseEntity<>(); + for (String line : buffer.split("\n")) { + if (line.startsWith("eventId: ")) { + responseEntity.eventId(Integer.parseInt(line.substring(9))); + continue; + } + if (line.startsWith("event: ")) { + responseEntity.event(line.substring(7)); + continue; + } + if (line.startsWith("retry: ")) { + responseEntity.retry(Long.parseLong(line.substring(7))); + continue; + } + if (line.startsWith("data: ")) { + responseEntity.data(RestObjectMapperFactory.getRestObjectMapper() + .readValue(line.substring(6), type)); + } + } Review Comment: 这里要不要加个消息合法性校验, 比如之前集成测试遇到过的消息粘包导致的解析问题. 如果字段重复了, 打一个告警日志会好分析很多. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
