humingcheng commented on code in PR #1522:
URL:
https://github.com/apache/servicecomb-service-center/pull/1522#discussion_r2700778654
##########
server/metrics/meta.go:
##########
@@ -59,12 +62,19 @@ func InitMetaMetrics() (err error) {
return
}
if err = metrics.CreateGauge(metrics.GaugeOpts{
- Key: KeyServiceTotal,
+ Key: KeyMicroserviceTotal,
Review Comment:
这个解释会暴露到metrics接口中，要说明指标的明确含义，即不区分version的微服务格数
##########
datasource/etcd/metrics.go:
##########
@@ -99,6 +103,7 @@ func reportServices(ctx context.Context, r
datasource.MetricsReporter) {
return
}
isMetricSet := false
+ recordedMetricsService := make(map[string]bool, len(servicesResp.Kvs))
Review Comment:
改成map[string]struct{}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
