Author: gertv
Date: Mon Jun  1 11:26:56 2009
New Revision: 780619

URL: http://svn.apache.org/viewvc?rev=780619&view=rev
Log:
SMXCOMP-495: Avoid copying the MessageExchange into multiple JbiExchanges

Modified:
    
servicemix/components/engines/servicemix-camel/trunk/src/main/java/org/apache/servicemix/camel/JbiExchange.java
    
servicemix/components/engines/servicemix-camel/trunk/src/test/java/org/apache/servicemix/camel/JbiInOnlyTest.java

Modified: 
servicemix/components/engines/servicemix-camel/trunk/src/main/java/org/apache/servicemix/camel/JbiExchange.java
URL: 
http://svn.apache.org/viewvc/servicemix/components/engines/servicemix-camel/trunk/src/main/java/org/apache/servicemix/camel/JbiExchange.java?rev=780619&r1=780618&r2=780619&view=diff
==============================================================================
--- 
servicemix/components/engines/servicemix-camel/trunk/src/main/java/org/apache/servicemix/camel/JbiExchange.java
 (original)
+++ 
servicemix/components/engines/servicemix-camel/trunk/src/main/java/org/apache/servicemix/camel/JbiExchange.java
 Mon Jun  1 11:26:56 2009
@@ -80,11 +80,7 @@
 
     @Override
     public org.apache.camel.Exchange newInstance() {    
-        if (messageExchange == null) {
-            return new JbiExchange(this.getContext(), this.getBinding());
-        } else {
-            return new JbiExchange(this.getContext(), this.getBinding(), 
this.getMessageExchange());
-        }
+        return new JbiExchange(this.getContext(), this.getBinding());
     }
     
     @Override
@@ -198,11 +194,14 @@
         }
     }
 
+    /**
+     * Detach from the underlying JBI {...@link MessageExchange}
+     * 
+     * @return the underlying {...@link MessageExchange}
+     */
     public MessageExchange detach() {
-        try {
-            return messageExchange;
-        } finally {
-            messageExchange = null;
-        }
+        MessageExchange result = messageExchange;
+        messageExchange = null;
+        return result;
     }
 }

Modified: 
servicemix/components/engines/servicemix-camel/trunk/src/test/java/org/apache/servicemix/camel/JbiInOnlyTest.java
URL: 
http://svn.apache.org/viewvc/servicemix/components/engines/servicemix-camel/trunk/src/test/java/org/apache/servicemix/camel/JbiInOnlyTest.java?rev=780619&r1=780618&r2=780619&view=diff
==============================================================================
--- 
servicemix/components/engines/servicemix-camel/trunk/src/test/java/org/apache/servicemix/camel/JbiInOnlyTest.java
 (original)
+++ 
servicemix/components/engines/servicemix-camel/trunk/src/test/java/org/apache/servicemix/camel/JbiInOnlyTest.java
 Mon Jun  1 11:26:56 2009
@@ -116,8 +116,10 @@
                     }
                 });
                 from("jbi:service:urn:test:in-only-aggregator")
+                    .to("log:info")
                     .aggregator(header("key"))
                     .setHeader("aggregated").constant(true)
+                    .to("log:info")
                     .to("mock:aggregated");
             }
         };


Reply via email to