svn commit: r453500 - in /shale/sandbox/shale-dialog2/src/main/java/org/apache/shale/dialog2: DialogContext.java base/AbstractDialogContext.java

[rahul]

Author: rahul
Date: Thu Oct  5 22:16:43 2006
New Revision: 453500

URL: http://svn.apache.org/viewvc?view=rev&rev=453500
Log:
Align listener registration method signatures with JavaBeans specification.

Modified:
    
shale/sandbox/shale-dialog2/src/main/java/org/apache/shale/dialog2/DialogContext.java
    
shale/sandbox/shale-dialog2/src/main/java/org/apache/shale/dialog2/base/AbstractDialogContext.java

Modified: 
shale/sandbox/shale-dialog2/src/main/java/org/apache/shale/dialog2/DialogContext.java
URL: 
http://svn.apache.org/viewvc/shale/sandbox/shale-dialog2/src/main/java/org/apache/shale/dialog2/DialogContext.java?view=diff&rev=453500&r1=453499&r2=453500
==============================================================================
--- 
shale/sandbox/shale-dialog2/src/main/java/org/apache/shale/dialog2/DialogContext.java
 (original)
+++ 
shale/sandbox/shale-dialog2/src/main/java/org/apache/shale/dialog2/DialogContext.java
 Thu Oct  5 22:16:43 2006
@@ -147,10 +147,8 @@
      * Listener cannot be <code>null</code>.
      *
      * @param listener The [EMAIL PROTECTED] DialogListener} instance.
-     * @return <code>true</code>, if the listener is added, or
-     *         <code>false</code>, if it has already been added
      */
-    public boolean addListener(DialogListener listener);
+    public void addDialogListener(DialogListener listener);
 
 
     /**
@@ -159,10 +157,8 @@
      * associated callbacks.
      *
      * @param listener The [EMAIL PROTECTED] DialogListener} instance.
-     * @return <code>true</code>, if this list was removed, or
-     *         <code>false</code>, if this listener was not registered
      */
-    public boolean removeListener(DialogListener listener);
+    public void removeDialogListener(DialogListener listener);
 
 
 }

Modified: 
shale/sandbox/shale-dialog2/src/main/java/org/apache/shale/dialog2/base/AbstractDialogContext.java
URL: 
http://svn.apache.org/viewvc/shale/sandbox/shale-dialog2/src/main/java/org/apache/shale/dialog2/base/AbstractDialogContext.java?view=diff&rev=453500&r1=453499&r2=453500
==============================================================================
--- 
shale/sandbox/shale-dialog2/src/main/java/org/apache/shale/dialog2/base/AbstractDialogContext.java
 (original)
+++ 
shale/sandbox/shale-dialog2/src/main/java/org/apache/shale/dialog2/base/AbstractDialogContext.java
 Thu Oct  5 22:16:43 2006
@@ -47,10 +47,8 @@
      * Listener cannot be <code>null</code>.
      *
      * @param listener The [EMAIL PROTECTED] DialogListener} instance.
-     * @return <code>true</code>, if the listener is added, or
-     *         <code>false</code>, if it has already been added
      */
-    public boolean addListener(DialogListener listener) {
+    public void addDialogListener(DialogListener listener) {
 
         if (listener == null) {
             throw new IllegalArgumentException("Cannot register null 
DialogListener");
@@ -58,10 +56,10 @@
 
         synchronized (listeners) {
             if (listeners.contains(listener)) {
-                return false;
+                throw new IllegalArgumentException("DialogListener already 
registered");
             }
             listener.setDialogContext(this); // attach self reference
-            return listeners.add(listener);
+            listeners.add(listener);
         }
     }
 
@@ -72,10 +70,8 @@
      * associated callbacks.
      *
      * @param listener The [EMAIL PROTECTED] DialogListener} instance.
-     * @return <code>true</code>, if this list was removed, or
-     *         <code>false</code>, if this listener was not registered
      */
-    public boolean removeListener(DialogListener listener) {
+    public void removeDialogListener(DialogListener listener) {
 
         if (listener == null) {
             throw new IllegalArgumentException("Cannot remove null 
DialogListener");
@@ -88,7 +84,6 @@
         if (removed) {
             listener.setDialogContext(null); // detach self reference
         }
-        return removed;
 
     }