svn commit: r958700 - in /shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets: rewrite/BaseTagRemoverRewriter.java servlet/HtmlAccelServlet.java

[lindner]

Author: lindner
Date: Mon Jun 28 20:09:57 2010
New Revision: 958700

URL: http://svn.apache.org/viewvc?rev=958700&view=rev
Log:
Patch from Jan Luehe | Compute log output only if needed

Modified:
    
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/BaseTagRemoverRewriter.java
    
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java

Modified: 
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/BaseTagRemoverRewriter.java
URL: 
http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/BaseTagRemoverRewriter.java?rev=958700&r1=958699&r2=958700&view=diff
==============================================================================
--- 
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/BaseTagRemoverRewriter.java
 (original)
+++ 
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/BaseTagRemoverRewriter.java
 Mon Jun 28 20:09:57 2010
@@ -25,6 +25,7 @@ import org.w3c.dom.Document;
 import org.w3c.dom.Element;
 import org.w3c.dom.NodeList;
 
+import java.util.logging.Level;
 import java.util.logging.Logger;
 
 /**
@@ -41,9 +42,9 @@ public class BaseTagRemoverRewriter impl
       Element baseElement = (Element) list.item(i);
       baseElement.getParentNode().removeChild(baseElement);
 
-      if (baseElement.hasAttribute("href")) {
+      if (baseElement.hasAttribute("href") && logger.isLoggable(Level.FINE)) {
         logger.fine("Removing base tag pointing to: "
-                    + baseElement.getAttribute("href") + "for gadget: "
+                    + baseElement.getAttribute("href") + " for gadget: "
                     + gadget.getContext().getUrl().toString());
       }
     }

Modified: 
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java
URL: 
http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java?rev=958700&r1=958699&r2=958700&view=diff
==============================================================================
--- 
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java
 (original)
+++ 
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HtmlAccelServlet.java
 Mon Jun 28 20:09:57 2010
@@ -23,6 +23,7 @@ import org.apache.shindig.common.servlet
 import org.apache.shindig.gadgets.GadgetContext;
 
 import java.io.IOException;
+import java.util.logging.Level;
 import java.util.logging.Logger;
 
 import javax.servlet.http.HttpServletRequest;
@@ -49,7 +50,9 @@ public class HtmlAccelServlet extends In
   @Override
   protected void doGet(HttpServletRequest request, HttpServletResponse 
response)
       throws IOException {
-    logger.fine("accel request = " + request.toString());
+    if (logger.isLoggable(Level.FINE)) {
+      logger.fine("accel request = " + request.toString());
+    }
     accelHandler.fetch(request, response);
   }